Skip to content

Layer views - reduced css changes.#2697

Draft
cityremade wants to merge 17 commits intoGEOLYTIX:minorfrom
cityremade:layer_views_minimal
Draft

Layer views - reduced css changes.#2697
cityremade wants to merge 17 commits intoGEOLYTIX:minorfrom
cityremade:layer_views_minimal

Conversation

@cityremade
Copy link
Copy Markdown
Member

@cityremade cityremade commented Mar 5, 2026

Introduced layout changes

  • Updated default palette - new base colour introduced for content layout readability.
  • Equivalent colour added to dark mode with addition to palette documentation.
  • .no-select class now applied on drawer headers and layer meta elements - previously each had a set of no-select rules in respective stylesheets. Redundant rules removed.
  • drawer and layerview stylesheets cleaned up - redundant rules moved to lower level drawer stylesheet, improved notation and order for nested rules.
  • location view - hierarchy of colours to follow the layer view logic, that is: base -> secondary -> tertiary. Previously it would follow base -> tertiary -> secondary which caused readability clashes against inputs and dropdowns.
  • dropdown background now base-tertiary to contrast correctly against drawers.
  • layer view stylesheet - css selectors detached from .drawer class.
  • location view - aligned padding, now header has the same padding on both sides. Selectors detached from .drawer class.
  • dark mode palette - colours for secondary and tertiary switched over, previously tertiary would be darker than secondary which didn't work at all times.
  • drawer - expanded drawers now have a flat look with a border.
  • .layer-view, .layer-group, .location-view - collapsed drawers have box shadow which is a better indication that the element has inner content.
    * .layer group - font in primary colour for distinction. bg colour does enough.

Change from the previous PR:

  • fourth base colour applied only on layer-group container
  • box-shadow on collapsed drawers only when they have .layer-view, .layer-group, .location-view classes.
  • inner drawers without box-shadow which would previously visually overtake buttons.

@cityremade cityremade self-assigned this Mar 5, 2026
@cityremade cityremade linked an issue Mar 5, 2026 that may be closed by this pull request
@cityremade cityremade marked this pull request as ready for review March 5, 2026 13:39
@cityremade cityremade added Code Issues related to the code structure and performance. CSS Changes in stylesheets labels Mar 5, 2026
@cityremade
Copy link
Copy Markdown
Member Author

cityremade commented Mar 5, 2026

I'm in two minds over group header in primary colour. no more.

Copy link
Copy Markdown
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All drawers seem to be always expanded.

20260305-1601-48.1792051.mp4

@cityremade
Copy link
Copy Markdown
Member Author

should be fixed now.

@cityremade cityremade requested a review from dbauszus-glx March 5, 2026 20:26
Copy link
Copy Markdown
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably remove these rules as they don't add a lot but seem to clutter up the space with an additional border.

.drawer {
    &.expanded {
        & > .header {
            /* border-bottom: solid 1px var(--color-border); */
            /* margin-bottom: 7px; */
        }
    }
}

More importantly. If you disable the rules and increase the screen scale you can see an issue with the padding. The header should not have a different padding than the content.

Image

I am happy to address the issue with header text hirarchy in a different PR or here.

Currently the group is bold, the layer is thin, and drawer header in a layer view are bold making these standout moore than the actual layer header.

@cityremade
Copy link
Copy Markdown
Member Author

cityremade commented Mar 6, 2026

ok so I've moved the bottom border on the header rule out of the drawer and into the layerview.

this is indeed too much right now.

yet this helps a lot with readability even if it only comes at top levels - layer group, layer view.

Screenshot 2026-03-06 at 12 02 24

so the inner drawer is still a bit plain but we can't address it without addressing buttons and other important interactive elements.

@cityremade cityremade requested a review from dbauszus-glx March 6, 2026 11:03
@dbauszus-glx
Copy link
Copy Markdown
Member

Padding should be applied to the drawer instead of a margin to the first child of the header. This ensures that the content and the header are equally padded. Previously the margin of the header exceeded the content of the drawer which looked odd.

image

@dbauszus-glx
Copy link
Copy Markdown
Member

The extra bottom border and margin on an expanded layer / group header doesn't add much. ec9cbe7

image

@RobAndrewHurst RobAndrewHurst marked this pull request as draft March 16, 2026 06:04
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Issues related to the code structure and performance. CSS Changes in stylesheets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate drawer and layer-view css classes

3 participants