Enhancements to confirm and alert dialogs#2728
Open
cityremade wants to merge 4 commits intoGEOLYTIX:minorfrom
Open
Enhancements to confirm and alert dialogs#2728cityremade wants to merge 4 commits intoGEOLYTIX:minorfrom
cityremade wants to merge 4 commits intoGEOLYTIX:minorfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Introduced changes
header > h2. Now each dialog has h2 tag only, generated by dialog method.z-index: 1005from confirm/alert buttons, it did nothing.icon- header icons now added for readability. Setparams.iconto use any icon in the header for better readability and clear context. If unset, fallback to defaults.innerContent- allows adding custom html fragment instead of text only as well as separation of custom html and functional buttons.