Skip to content

Enhancements to confirm and alert dialogs#2728

Open
cityremade wants to merge 4 commits intoGEOLYTIX:minorfrom
cityremade:ui_confirm_alert
Open

Enhancements to confirm and alert dialogs#2728
cityremade wants to merge 4 commits intoGEOLYTIX:minorfrom
cityremade:ui_confirm_alert

Conversation

@cityremade
Copy link
Copy Markdown
Member

@cityremade cityremade commented Mar 27, 2026

Introduced changes

  • alert/confirm css - removed rules for inverted background and font colour, removed header border. Header now plain.
  • removed redundant h4 tag nested inside header > h2. Now each dialog has h2 tag only, generated by dialog method.
  • buttons now outlined and inside a flexbox aligned right.
  • text now aligned left, previously centered which would make it look like a poem.
  • removed fixed z-index: 1005 from confirm/alert buttons, it did nothing.
  • new property icon - header icons now added for readability. Set params.icon to use any icon in the header for better readability and clear context. If unset, fallback to defaults.
  • new property innerContent - allows adding custom html fragment instead of text only as well as separation of custom html and functional buttons.
  • cancel/ok buttons now outside customisable dialog content.
  • minor scaling effect on buttons in active state, it gives users response that the button has been clicked.
  • updated docs.
Screenshot 2026-03-27 at 16 11 20

@cityremade cityremade self-assigned this Mar 27, 2026
@cityremade cityremade linked an issue Mar 27, 2026 that may be closed by this pull request
@cityremade cityremade added CSS Changes in stylesheets UI labels Mar 27, 2026
@cityremade cityremade marked this pull request as ready for review March 27, 2026 15:14
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CSS Changes in stylesheets UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTML content for alert / confirm dialog elements

1 participant