fix: Fix RLF coloring #3814
Open
fix: Fix RLF coloring #3814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveltomin
approved these changes
Sep 30, 2025
bd713
added
the
ci: run integrated tests
bd713
added
flag: ready for review
flag: requires rebaseline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses review feedback from #3711:
size_tscattervinMpiWrapperAdditionally, parallel unit tests now use 4 MPI ranks max, instead of 8 to reduce testing overhead.
Rebaseline required
The color assigned to a given MPI rank may differ from the previous implementation.
This affects 6 contact mechanics use cases.
Component-wise
displacementJumpcan show large differences, but these are due to normal vector sign flips on some elements. These sign flips affect the polarity of tangential displacement components but do not change the physics.The displacement magnitude comparisons shows a good agreement with the original baseline: