Skip to content

Conversation

@MelReyCG
Copy link
Contributor

@MelReyCG MelReyCG commented Oct 8, 2025

This PR is based on Amandine work on adding error YAML file in GEOS (PR #3828), and aims at adding a detection & management inside GEOS of 1. Error signals, 2. External errors from dependencies, in order to be able to manage & output them in the log & error YAML file.

Managing those external errors gives us the opportunity to:

  • detect any kernel / system allocator errors,
  • add the stack-trace of the error,
  • output them reliably in the log, even if the stderr get lost or used for another reason,
  • factorize them with external tools / scripts, thus highlighting which are the source rank(s) of the issue.

This PR also prevent the stacktrace to be cut by other ranks message, which could previously happen on a signal.

We can imagine adding later some tag for each dependency (system, LvArray, Hypre, ...) to quickly identify / filter issues source.


(Replaces #3722)

… link between GEOS_THROW_CTX_IF and LVARRAY_THROW_IF_TEST( EXP, MSG, TYPE )
… in try/catch statements

Problem: Retrieves everything that was thrown, so not just the message.
…y spaces.

The previous condition checked whether an argument was present and whether the option was immediately followed by a value like -test"value", which excluded valid cases like -test "value" et -test     "value".
@paveltomin
Copy link
Collaborator

@rrsettgast @wrtobin @paveltomin I need a review, this work will be useful for further debugging tasks

i more or less understand what is done here but don't really understand how it works, sorry
seems very low-level, can you share some examples - situation before and after ?

@MelReyCG
Copy link
Contributor Author

MelReyCG commented Nov 5, 2025

@paveltomin thanks for the feedback, I'll work on the code clarity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants