Fix/oduran/consistent compositional buoyant flux #3872
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip: completing implementation of face BC Update CompositionalMultiphaseHybridFVM.cpp
…phaseHybridFVM.cpp Co-authored-by: Copilot <[email protected]>
…n/weak_dirichlet_bc_mfd
OmarDuran
added
the
ci: run code coverage
…ace component fractions
…tionalMultiPhaseMFDPolyhedral.cpp Co-authored-by: Nicola Castelletto <[email protected]>
…tionalMultiPhaseMFDPolyhedral.cpp Co-authored-by: Nicola Castelletto <[email protected]>
…tionalMultiPhaseMFDPolyhedral.cpp Co-authored-by: Nicola Castelletto <[email protected]>
…/GEOS-DEV/GEOS into fix/oduran/weak_dirichlet_bc_mfd
…stent_compositional_buoyant_flux
…stent_compositional_buoyant_flux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with refactoring the buoyant flux part in the compositional MFD component. This PR depends on PR #3765
To achieve a consistent implementation of gravity fluxes two concepts are introduced, the trace of the quantity:
(rho_delta - rho_gamma) K grad (z) which is the driving buoyant flux. the trace of the full buoyant flux associated with the pair phase delta - gamma. the traces of total mass mobility \Lambda and the phase mobilities lambda_delta and lambda_gamma are defined by the upwind scheme in question, in this case Hybrid upwinding.