fix: Add Clang warning flag to suppress 64-to-32 bit conversion warnings #3892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarDuran
added
ci: run CUDA builds
OmarDuran
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3892 +/- ##
========================================
Coverage 58.94% 58.94%
========================================
Files 1326 1326
Lines 109524 109524
========================================
+ Hits 64557 64559 +2
+ Misses 44967 44965 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 4fd50e1.
Member
|
We shouldn't do this. We should fix the problem instead. Can you output an example of the warnings? I don't see them on my Mac. If the operations is OK, i.e. our integer_conversion routines, then we can isolate the warning suppression with pragmas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
-Wno-shorten-64-to-32to Clang warning flags to suppress noisy 64-to-32 bit conversion warnings while keeping other strict checks enabled.This PR is connected with issue #3893