Skip to content

feat: MultiPhase Poromechanics Conforming Fractures (ALM) #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jhuang2601 wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

feat: MultiPhase Poromechanics Conforming Fractures (ALM) #3926

jhuang2601 wants to merge 15 commits into from
+828 −194

Conversation

@jhuang2601
Copy link
Contributor

@jhuang2601 jhuang2601 commented Dec 18, 2025 •
edited
Loading

This PR couples the ALM solver with multiphase flow in sequential mode

@jhuang2601 jhuang2601 self-assigned this Dec 18, 2025
@jhuang2601 jhuang2601 added type: feature New feature or request EPIC - FF/Contact Contact mechanics EPIC - FF/Solvers labels Dec 18, 2025
@jhuang2601 jhuang2601 marked this pull request as ready for review December 19, 2025 01:50
@jhuang2601 jhuang2601 marked this pull request as draft December 19, 2025 02:26
@jhuang2601 jhuang2601 marked this pull request as ready for review December 19, 2025 19:44
jafranc
jafranc approved these changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@jafranc jafranc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !! Thanks @jhuang2601

...coreComponents/physicsSolvers/multiphysics/MultiphasePoromechanicsConformingFracturesALM.hpp
Comment on lines +117 to +118
static const localIndex m_maxFaceNodes=11; // Maximum number of nodes on a contact face

Copy link
Contributor

@jafranc jafranc Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should somehow be set in a parent class instead of hard-copied from implementation to implementation

@jafranc
Copy link
Contributor

jafranc commented Dec 22, 2025 •
edited
Loading

Maybe a quick test will add to CI strength

paveltomin
paveltomin approved these changes Jan 8, 2026
View reviewed changes
Copy link
Collaborator

@paveltomin paveltomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine as a first step
code duplication should be definitely addressed in a subsequent PR

for this PR my only small request is to add a test case, will simplify refactoring and extension later

@jhuang2601 jhuang2601 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs flag: requires rebaseline Requires rebaseline branch in integratedTests labels Jan 8, 2026
@jhuang2601
Copy link
Contributor Author

jhuang2601 commented Jan 8, 2026

looks fine as a first step code duplication should be definitely addressed in a subsequent PR

for this PR my only small request is to add a test case, will simplify refactoring and extension later

Sure, a smoke test with two curved fractures is added.

@jhuang2601
Copy link
Contributor Author

jhuang2601 commented Jan 8, 2026

Expected failure and hence rebaseline is required

=======================
Test failures
=======================
ALM_multiphasePoromechanics_curvedFrac_smoke_01
ALM_multiphasePoromechanics_curvedFrac_smoke_02
ALM_singlephasePoromechanics_curvedFrac_smoke_01
ALM_singlephasePoromechanics_curvedFrac_smoke_02
=======================
Overall status: FAILED
=======================

@codecov
Copy link

codecov bot commented Jan 8, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 4.91803% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.90%. Comparing base (58178e4) to head (180e9bd).

Files with missing lines Patch % Lines
.../MultiphasePoromechanicsConformingFracturesALM.cpp 0.00% 46 Missing ⚠️
.../MultiphasePoromechanicsConformingFracturesALM.hpp 20.00% 12 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3926      +/-   ##
===========================================
- Coverage    58.93%   58.90%   -0.04%     
===========================================
  Files         1351     1353       +2     
  Lines       112834   112895      +61     
===========================================
+ Hits         66499    66500       +1     
- Misses       46335    46395      +60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paveltomin paveltomin paveltomin approved these changes

@herve-gross herve-gross herve-gross approved these changes

@jafranc jafranc jafranc approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@frankfeifan frankfeifan Awaiting requested review from frankfeifan frankfeifan is a code owner

@Guotong-Ren Guotong-Ren Awaiting requested review from Guotong-Ren Guotong-Ren is a code owner

@npillardou npillardou Awaiting requested review from npillardou

@bd713 bd713 Awaiting requested review from bd713

@matteofrigo5 matteofrigo5 Awaiting requested review from matteofrigo5 matteofrigo5 is a code owner

Assignees

@jhuang2601 jhuang2601

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI EPIC - FF/Contact Contact mechanics EPIC - FF/Solvers flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jhuang2601 @jafranc @paveltomin @herve-gross