fix: single phase statistics CSV generation #3928
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arng40
requested review from
CusiniM,
OmarDuran,
dkachuma,
paveltomin,
rasimHZ,
rrsettgast and
tjb-ltk
as code owners
arng40
added
type: bug
arng40
requested review from
castelletto1,
herve-gross and
jhuang2601
as code owners
paveltomin
approved these changes
Dec 22, 2025
herve-gross
approved these changes
Dec 22, 2025
MelReyCG
requested changes
Dec 29, 2025
Contributor
MelReyCG
left a comment
MelReyCG
left a comment
There was a problem hiding this comment.
Uniformize with the compositionalMultiphaseStatistics.cpp:
- use a TableLayout in the rows output
- Also, if it is not too much out of scope, you can keep the formatter as a private member (preventing any different parameter count in the CSV header & data)
MelReyCG
added
ci: run CUDA builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing "," in csv headers and average/min pressure have been reversed