Skip to content

Conversation

@dkachuma
Copy link
Contributor

@dkachuma dkachuma commented Feb 3, 2026

Adds a reference thermal conductivity. The point of this is that the user might want this to be read from the vtk file for example. So we separate this from the effective thermal conductivity which is the calculated output from the thermal conductivity model.

#3956

Rebaseline to fix errors of type

********************************************************************************
Error: /Problem/domain/MeshBodies/mesh1/meshLevels/Level0/ElementRegions/elementRegionsGroup/region/elementSubRegions/cb
	Group has a child 'thermalCond_linear_referenceThermalConductivity' in the file to compare but not the baseline file.
********************************************************************************

which is expected because this change introduces this new wrapper.

@dkachuma dkachuma self-assigned this Feb 3, 2026
@dkachuma dkachuma added type: feature New feature or request ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: requires rebaseline Requires rebaseline branch in integratedTests ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Feb 3, 2026
@dkachuma dkachuma requested a review from sytuannguyen February 3, 2026 18:14
@dkachuma dkachuma linked an issue Feb 3, 2026 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 63.15789% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.89%. Comparing base (5abf149) to head (8513525).

Files with missing lines Patch % Lines
...malConductivity/SinglePhaseThermalConductivity.cpp 84.00% 4 Missing ⚠️
...ers/surfaceGeneration/EmbeddedSurfaceGenerator.cpp 0.00% 4 Missing ⚠️
...sicsSolvers/surfaceGeneration/SurfaceGenerator.cpp 0.00% 4 Missing ⚠️
...onductivity/SinglePhaseThermalConductivityBase.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3959      +/-   ##
===========================================
- Coverage    58.89%   58.89%   -0.01%     
===========================================
  Files         1353     1353              
  Lines       113035   113065      +30     
===========================================
+ Hits         66573    66589      +16     
- Misses       46462    46476      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@OmarDuran OmarDuran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkachuma thank you for your contribution. The modifications in the SurfaceGenerators look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import thermal conductivity fails on ThermalSinglePhaseFluid

3 participants