-
Notifications
You must be signed in to change notification settings - Fork 99
feat: Add reference thermal conductivity #3959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3959 +/- ##
===========================================
- Coverage 58.89% 58.89% -0.01%
===========================================
Files 1353 1353
Lines 113035 113065 +30
===========================================
+ Hits 66573 66589 +16
- Misses 46462 46476 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OmarDuran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkachuma thank you for your contribution. The modifications in the SurfaceGenerators look good.
Adds a reference thermal conductivity. The point of this is that the user might want this to be read from the vtk file for example. So we separate this from the effective thermal conductivity which is the calculated output from the thermal conductivity model.
#3956
Rebaseline to fix errors of type
which is expected because this change introduces this new wrapper.