-
Notifications
You must be signed in to change notification settings - Fork 99
fix: Add fix to fracture state in case of high cohesion #3964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3964 +/- ##
===========================================
- Coverage 58.87% 58.87% -0.01%
===========================================
Files 1353 1353
Lines 112953 112964 +11
===========================================
Hits 66504 66504
- Misses 46449 46460 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if( currentTau > limitTau ) | ||
| { | ||
| // Tangential traction exceeds cohesion limit: transition to slip | ||
| LvArray::tensorOps::fill< 3 >( localTractionNew, 0.0 ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@castelletto1 @jafranc
If fields::contact::FractureState::Slip, why zero out localTractionNew?
For open element, it is correct; but for the slipped ones, I guess the normal traction (localTractionNew[0]) should be preserved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right, I kept it the same as before, but logically the traction should remain the same, if not zero.
This PR tries to correct a condition found in the ALM method.
The implementation is based from the LM method ( physicsSolvers/solidMechanics/contact/SolidMechanicsLagrangeContact.cpp:2274-2335) :
Some tests have been performed showing a better consistency in Aramis case with very high cohesion (1e20):

Previous implementation:
With the fix:
