Additional information on the table log perforation #3966
+65
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arng40
added
type: feature
arng40
requested review from
OmarDuran,
rrsettgast and
wrtobin
as code owners
Melcx
reviewed
Feb 9, 2026
Comment on lines
565
to
570
| /// The reservoir element that contains the perforation | ||
| globalIndex m_reservoirElementID; | ||
| /// the target region name for the reservoir element | ||
| string m_regionName; | ||
| /// the target sub region name for the reservoir element | ||
| string m_subRegionName; |
There was a problem hiding this comment.
A WellElementSubRegion can only have one communicating region cell element?
Isn't this data already stored somewhere?
Contributor
Author
There was a problem hiding this comment.
yep I revert wellElementSubRegion cpp & hpp
Comment on lines
497
to
499
| localIndex & esrMatched, | ||
| localIndex & eiMatched, | ||
| globalIndex & giMatched, |
There was a problem hiding this comment.
As you may have a lot of parameters here, maybe a functor with a structured parameter would be simpler to call than a lot of in-out parameters.
Also, the return type is not documented, it is a EOF-style-bool, right? With a functor you could have the loop inside of the search method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the modification :
After