feat: Separate Mobile and Immobile Parts of Aggregate Species Concentrations#10
Closed
frankfeifan wants to merge 1 commit intomainfrom
Closed
feat: Separate Mobile and Immobile Parts of Aggregate Species Concentrations#10frankfeifan wants to merge 1 commit intomainfrom
frankfeifan wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to separate the mobile and immobile parts of each aggregate species in HPCReact. It is motivated by the fact that in some systems, the secondary species can be either mobile or immobile, so when doing reaction transport on the aggregate species concentrations, we should only transport the mobile part in the flux assembly while use the entire aggregate concentration in the accumulation assembly.
The main changes include:
m_mobileSecondarySpeciesFlagin bothEquilibriumReactionsParametersandMixedReactionParametersto indicate the mobility of the secondary species:1if mobile and0if immobile.massActionsthat separates the update for the total and mobile aggregate species concentration.massActionsin the mixed system update.