feat: add mixed equilibrium and kinetic reactions#4
Merged
rrsettgast merged 29 commits intomainfrom Jun 18, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 13 17 +4
Lines 520 713 +193
==========================================
+ Hits 520 713 +193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ini/mixed-reactions
Collaborator
Author
|
this is now ready for review and potentially to be merged. |
rrsettgast
approved these changes
Jun 18, 2025
Comment on lines
+58
to
+64
| constexpr CArrayWrapper( CArrayWrapper const & src ) | ||
| { | ||
| for( std::size_t i = 0; i < DIM0; i++ ) | ||
| { | ||
| data[i] = src.data[i]; | ||
| } | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
I added these copy constructors so that I could do this:
Can't remembe if it's also done for 1d arrays.
Collaborator
Author
There was a problem hiding this comment.
looks like it is here:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.