Skip to content

Conversation

rtodling
Copy link
Contributor

This is likely an ESMF issue; the tablend parameter never becomes true and the code hits the end of table ... so I put a check to the RC in order to stop the reading of the table. This addresses issue #122

@rtodling rtodling requested review from a team as code owners January 28, 2025 22:41
Copy link

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Please add one so that the PR can be merged.

Copy link

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Please add one so that the PR can be merged.

@mathomp4 mathomp4 marked this pull request as draft February 20, 2025 23:37
@mathomp4
Copy link
Member

I'm not sure this is needed. I believe issue was due to single-quotes in the rc file (a la #86)

@weiyuan-jiang
Copy link
Contributor

I am wondering if it is a right way to use the call. It should look like this:

call ESMF_ConfigNextLine     ( config,tableEnd=tend, rc=rc )
 do while (.not.tend)
       m = m+1
       allocate( quadtmp(3,m) )
       call ESMF_ConfigGetAttribute ( config,value=name1,   rc=rc )
       call ESMF_ConfigNextLine     ( config,tableEnd=tend, rc=rc )
       if (tend) exit
       call ESMF_ConfigGetAttribute ( config,value=dummy,   rc=rc )
       call ESMF_ConfigNextLine     ( config,tableEnd=tend, rc=rc )
       if (tend) exit
       call ESMF_ConfigGetAttribute ( config,value=name2,   rc=rc )
       call ESMF_ConfigNextLine     ( config,tableEnd=tend, rc=rc )
       if (tend) exit
       call ESMF_ConfigGetAttribute ( config,value=dummy,   rc=rc )
       call ESMF_ConfigNextLine     ( config,tableEnd=tend, rc=rc )
       if (tend) exit
       call ESMF_ConfigGetAttribute ( config,value=name3,default='XXX',rc=rc )
      call ESMF_ConfigNextLine     ( config,tableEnd=tend, rc=rc )

enddo

@mathomp4
Copy link
Member

I am wondering if it is a right way to use the call. It should look like this:

Hmm. I defer to @bena-nasa

@bena-nasa
Copy link
Contributor

I don't quite get what @weiyuan-jiang is saying. Where is the table we need to parse, does it only have one item per line, I thought these tables have more than one item per line, so why would you do getnextline after getting each item, did it change?

@weiyuan-jiang
Copy link
Contributor

Please copy the section of the rc file here so we can understand how to read it. @rtodling

Copy link

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Please add one so that the PR can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants