Merged
Conversation
rtodling
approved these changes
Jan 14, 2026
Collaborator
rtodling
left a comment
There was a problem hiding this comment.
These changes work for me; and indeed give zero diff to results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Update of ana.rc.tmpl with NOAA 20 filename
-Update psas.rc with VIIRS names but also obs errors
•Buddy Check: m_sqc.F90 updated with openMP that works. Original code crashes with segmentation fault when turning on openMP. New code is 0 diff to the old code if you turn off openMP and 0 diff between openMP on/off
•GAAS_App/CMakeLists.txt: target_link_libraries(${this} PRIVATE OpenMP::OpenMP_Fortran)
•Needs setenv OMP_NUM_THREADS 20 (I tested with 20 and works quite fast)
•When running offline this appears: in ana_aod.csh:
# Running environment
# -------------------
set NCPUS = $cpu
limit stack unlimited
setenv ARCH
uname -ssetenv PSAS_NUM_MPI $NCPUS # for PSAS
setenv MPIRUN "mpirun -np $PSAS_NUM_MPI"
setenv OMP_NUM_THREADS 20 # for SQC
Online: is it in ana_aod.j.tmpl? That setenv OMP_NUM_THREADS should be added. Should it come from higher up.