Update to match GEOSgcm main as of 2025-Mar-11 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
Non 0-diff
Contributor
|
I have modified the PR to the point where it can now run TR, GMI or Idealized Tracers. |
mmanyin
approved these changes
Apr 10, 2025
Contributor
mmanyin
left a comment
mmanyin
left a comment
There was a problem hiding this comment.
This is a good 'first crack' at this major update. Recommend merging at this point.
bena-nasa
approved these changes
Apr 10, 2025
Contributor
|
Is the "build test" actually functional these days? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to update the GEOSctm to match the
components.yamlof GEOSgcmmainas of 2025-Mar-11. This brings over the split chemistry, et al.It will probably also need many, many updates to things in GEOSctm_App. I tried to update a few but then...well, better to let @mmanyin or @JulesKouatchou figure that out.
My first step is "make it build". I'm going to see if the CI is happy so far.