Skip to content

add bkg.lfo collection & remove lfo Nx+- collection#719

Merged
sdrabenh merged 3 commits intodevelopfrom
feature/saraqzhang/addbkglfo2hist
May 29, 2025
Merged

add bkg.lfo collection & remove lfo Nx+- collection#719
sdrabenh merged 3 commits intodevelopfrom
feature/saraqzhang/addbkglfo2hist

Conversation

@saraqzhang
Copy link
Contributor

@saraqzhang saraqzhang commented Apr 23, 2025

Renames and updates the land forcing (lfo) Collections needed for coupled land-atmosphere data assimilation.
As implemented, the bkg.lfo* Collections are turned on by default, for consistency with the other bkg collections.

        remove lfo Nx+- collection
@saraqzhang saraqzhang requested a review from a team as a code owner April 23, 2025 18:02
@saraqzhang saraqzhang added enhancement New feature or request 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) labels Apr 23, 2025
@gmao-rreichle gmao-rreichle requested a review from rtodling April 29, 2025 19:30
@gmao-rreichle
Copy link
Contributor

@rtodling : @sdrabenh confirmed offline that he is ok with the changes. He's looking to you to approve and confirm that it's ok to have the bkg.lfo* output turned on by default.

@gmao-rreichle
Copy link
Contributor

@rtodling : @sdrabenh confirmed offline that he is ok with the changes. He's looking to you to approve and confirm that it's ok to have the bkg.lfo* output turned on by default.

Another ping on this PR, which is still awaiting approval by @rtodling. --- @sdrabenh: FYI, @rtodling merged GEOS-ESM/GEOSadas#327, which includes the wiring to always write the bkglfo collections, see discussion here: GEOS-ESM/GEOSadas#327 (comment). Maybe that's sufficient approval?

Copy link
Contributor

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine w/ me.

Copy link
Collaborator

@sdrabenh sdrabenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR is fine with @rtodling it is fine with me too

@sdrabenh sdrabenh merged commit 9384273 into develop May 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants