Skip to content

v12: Update regress, fix bug in gcm_run for OpenMP#725

Merged
mathomp4 merged 2 commits intofeature/sdrabenh/gcm_v12from
feature/v12-update-regress
May 6, 2025
Merged

v12: Update regress, fix bug in gcm_run for OpenMP#725
mathomp4 merged 2 commits intofeature/sdrabenh/gcm_v12from
feature/v12-update-regress

Conversation

@mathomp4
Copy link
Member

@mathomp4 mathomp4 commented May 6, 2025

This PR has two purposes.

  1. Fix a bug in gcm_run.j when running with more than one OpenMP thread. This fix was already in gcm_regress.j but apparently was not ported to gcm_run.j
  2. Update the gcm_regress.j script to use less resources
    1. We now do 12 hour runs with a 3+9 for start-stop and 3 hr for layout and OpenMP
    2. Change the layout run from 1-by-6 to NX-by-(NY/2)

I've also removed the NUM_WRITERS change in steps 4 and 5. It's causing some sort of issue, see GEOS-ESM/MAPL#3687

@mathomp4 mathomp4 self-assigned this May 6, 2025
@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label May 6, 2025
@mathomp4 mathomp4 marked this pull request as ready for review May 6, 2025 16:50
@mathomp4 mathomp4 requested a review from a team as a code owner May 6, 2025 16:50
@mathomp4 mathomp4 merged commit 810c535 into feature/sdrabenh/gcm_v12 May 6, 2025
13 of 15 checks passed
@mathomp4 mathomp4 deleted the feature/v12-update-regress branch May 6, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant