v12: Fix DataAtm Bug, make CICE6 default#735
Merged
sdrabenh merged 1 commit intofeature/sdrabenh/gcm_v12from Jun 4, 2025
Merged
v12: Fix DataAtm Bug, make CICE6 default#735sdrabenh merged 1 commit intofeature/sdrabenh/gcm_v12from
sdrabenh merged 1 commit intofeature/sdrabenh/gcm_v12from
Conversation
mathomp4
added
the
0 diff
Member
Author
|
I'll also ping @mfmehari on this, since it involves DataAtm. |
|
I noticed another minor bug (CICE4 gets added in 
|
Member
Author
|
Whoops. Let me fix that! ETA: Ahh @Dooruk that is in the older GCMv12-rc12 tag. I've made the fix in the build I made for you. That was fixed in v12 a bit ago. |
Ah I see, no problem, I wanted to make sure it doesn't go unnoticed. I will use a different HISTORY.rc. |
mfmehari
approved these changes
Jun 3, 2025
sdrabenh
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per @Dooruk, there is a bug in the v12 setup scripts. Namely,
GWD_IN_BCSisn't defined if you are running DataAtm. Oops.Also, in this PR I make CICE6 our default CICE model for v12. I mean, I run it now in my nightly. tests and I think @zhaobin74 and @sinakhani run with it.
I'll ask them for their thoughts on that.