Feature/rtodling/these read cubed output#1074
Merged
Conversation
Sync develop into main
Sync develop into main
Sync develop into main
rtodling
added
0 diff
sdrabenh
approved these changes
Apr 15, 2025
This was referenced Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a change that's been made some back in GEOSadas 5.40.x and has never been put in a PR (my fault).
This basically adds the capability of mkiau to read cubed analysis files - this is very important for handling JEDI-generated analyses files.
CAUTION: The annoying part about this PR is that the changes need to go in: (1) develop - there is no conflict; and they also need to be placed on top of v2.7.0 (there is also no conflict). Since my needs are immediate wrt to v2.7.0 I am targeting the changes to go there, it would be good to have a v2.7.0.1 tag issued that includes this change. The change should then be placed in develop - I can take care of adding another PR targeting to develop after 2.7.0.1 is created.
Thank you.
I am adding Ben Auer on this since he helped me implement these changes - which by now he might not even remember.