Integrate Python code that computes temperature increments via ML#1077
Merged
sdrabenh merged 8 commits intofeature/sdrabenh/gcm_v12from Apr 3, 2025
Merged
Conversation
…eature/pchakrab/mkiau-pyml-interface
…ments Renamed ... BUILD_PYMLINC_INTERFACE -> BUILD_WITH_PYMLINC (cmake option) PYMLINC_INTEGRATION -> HAS_PYMLINC (compile definition) Using BUILD_WITH_PYMLINC at a higher level (GCM), since we need it in AGCM and Physics to re-export the extra Q's and provide connectivity at the GCM level We need Q[L/I/R/S/G]TOT variables, instead of Q[L/I/R/S/G] Checking in Working code Working code - added U Working code - added V, T Working code - added rest of Q's Working code - added PS. All variables are have now been passed to Python Calling geos_state_bias code Checking in working version, before everything starts failing again Now working Still working Still working. Miracle! Still working Cleanup step 1 Cleanup step 2 Still working Working Working Working Only root calls pyMLINC's interface Working Working
…eature/pchakrab/mkiau-pyml-interface
pchakraborty
added
the
0 diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes an interface in MKIAU to the Python code to compute temperature increments via ML. The relevant code is built via the CMake option
BUILD_WITH_PYMLINC(as incmake -DBUILD_WITH_PYMLINC=On ...). This option sets the compile definitionHAS_PYMLINCthat activates the interface and the associated code that includes a newexportvariableDTDT_ML.The PR passes
gcm_regresstest and the 0-increment replay test.