Merged
Conversation
…APL, only: ...' statements
…ing divide by zero error)
pchakraborty
changed the title
There is a memory corruption happening somewhere in GWD. The 'lats' input of gw_beres_init is getting corrupted whenever 'desc%k' is allocated. The temporary solution is to move the allocation of 'desc%k' after the code block that uses 'lats'
pchakraborty
added
the
0 diff
bena-nasa
previously approved these changes
May 23, 2025
tclune
previously approved these changes
May 23, 2025
Collaborator
tclune
left a comment
tclune
left a comment
There was a problem hiding this comment.
The main thing that catches my eye is the USE statements.
Please open another ticket (maybe already exists) that would target the ability to replace all USE MAPL* and USE ESMF with a single USE MAPL3.
Collaborator
Author
Create #1107 |
mathomp4
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported GWD to MAPL3
NOTE: A memory corruption is happening somewhere in GWD. The
latsinput (intent(in)) ofgw_convect::gw_beres_initis getting corrupted wheneverdesc%kis allocated. The temporary solution is to move the allocation ofdesc%kafter the code block that useslats. This temporary solution seems to be working for the Intel compiler, may get different mileage with other compilers.Created issue #1106
Created issue #1107