[NDSL] Python UW Integration and general fixes#1153
Merged
FlorianDeconinck merged 129 commits intodsl/developfrom Sep 22, 2025
Merged
[NDSL] Python UW Integration and general fixes#1153FlorianDeconinck merged 129 commits intodsl/developfrom
FlorianDeconinck merged 129 commits intodsl/developfrom
Conversation
QSatIce missing before test can be done
Verbose the README
…. Fails to verify at majority of points using original metric, has not been tested with new metrics. Error patterns of the ES tables suggest arise during math within qsat_liquid and qsat_ice. Errors are small (10^-4). Further testing using find_klcl is in process to see if these errors propogate further or are locked within QSat.
…cil to calculate QSat for entire field, or function can be called from within the stencil to calculate QSat at individual points. To use function, the QSat class must be initialized before stencil call and the tables must be passed down to the function as an input.
…deal with reshaping 2D and 3D variables in translate test before calling stencil computation.
… but errors are very very small.
…2/6 variables. Some errors are very small and likely stem from multiplication with constants.
…ble pass. Very small errors still exist in 'ssthl0_test' that likely stem from multiplication with constants. A bug was found which does not allow functions to be called within while loops. A workaround has been implemented where this applies and errors are raised if certain conditions are not met.
… at less than 1%. Switched ndsl branches to unstable/develop.
…idComp into dsl/PyUW_Integration
…idComp into dsl/PyUW_Integration
…s something to revert back to if needed
FlorianDeconinck
added
the
0 diff trivial
FlorianDeconinck
requested review from
CharlesKrop
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Label explainer: NDSL code - not in production
Author: @katrinafandrich
TBD