Skip to content

Conversation

@narnold1
Copy link
Contributor

Limits the UW mass flux based on the CFL condition to reduce occurrence of large tendencies. Tests indicate minimal impact on UMF<0.15 kg/m2/s and temperature increments less than 5K, while UMF>0.2 and increments >10K are almost eliminated.

@narnold1 narnold1 requested review from a team as code owners September 10, 2025 14:37
@narnold1 narnold1 added the Non 0-diff The changes in this pull request are non-zero-diff label Sep 10, 2025
@mathomp4 mathomp4 changed the base branch from develop to feature/sdrabenh/gcm_v12 September 10, 2025 14:42
@mathomp4
Copy link
Member

@narnold1 I moved the base of this PR to feature/sdrabenh/gcm_v12 as it seemed to be based on that.

Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narnold1 : Thanks for the heads-up. No objections from the land team.

@mathomp4 mathomp4 linked an issue Sep 11, 2025 that may be closed by this pull request
@mathomp4 mathomp4 marked this pull request as draft September 19, 2025 12:39
@mathomp4 mathomp4 marked this pull request as ready for review September 19, 2025 12:39
@mathomp4 mathomp4 marked this pull request as draft September 19, 2025 12:39
@mathomp4
Copy link
Member

@narnold1 I moved the base of this PR to feature/sdrabenh/gcm_v12 as it seemed to be based on that.

@narnold1 This might have been a mistake on me because it seems like v12 already has this? The current conflict is:

<<<<<<< feature/narnold1/#1155_fix_uw_tendency -- Incoming Change
            ! Limit umf based on (2x) the CFL condition
            umf(k) = min(umf(k),2.*dp0(k)/g/dt)
            
=======
          ! --------------------------------------------------------- !
          ! Limit umf based on (2x) the CFL condition
          ! --------------------------------------------------------- !
            umf(k) = min(umf(k),2.*dp0(k)/g/dt)

>>>>>>> feature/sdrabenh/gcm_v12 -- Current Change

Did you mean to change this in GEOSgcm v11? Or, perhaps, did this change get into v12 via @wmputman or @sdrabenh from a different route?

@narnold1 narnold1 closed this Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Non 0-diff The changes in this pull request are non-zero-diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Large temperature increments from UW shallow convection

4 participants