Update to MAPL 2.55.0, GMAO_Shared 2.0.0, add GMAO_perllib 1.0.0 #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gmao-rreichle
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates GEOSldas to use MAPL 2.55. This is needed due to an update in GEOSgcm_GridComp
develop:GEOS-ESM/GEOSgcm_GridComp#1087
At the same time, I noticed GEOSldas was a bit behind GEOSgcm in GMAO_Shared. So I update it to v2.0.0 which means we need to bring in GMAO_perllib as a new repo.
Successfully 0-diff tested by @gmao-rreichle. For all tests with aggressive optimization, the comparison is non-0-diff within roundoff for the "cdcr1" variable in the (binary) catparam files. This variable is computed from other numbers in the bcs during pre-processing.