-
Notifications
You must be signed in to change notification settings - Fork 0
refactoring ldas_setup #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@weiyuan-jiang : Many thanks for getting a start on this. Perhaps hold off on editing ldas_setup for refactoring until #102 and #106 have been merged. With any luck, we can merge these PRs early this week. |
@weiyuan-jiang : When you get back to this PR, please include an optional SLURM/PBS parameter cc: @mathomp4 |
added ntasks-per-node
@gmao-rreichle I can merge PR #132 to this PR. Should I do that ? |
@saraqzhang Would you please test this PR in your GEOSadas run? I expect zero-diff. Thanks |
@weiyuan-jiang @gmao-rreichle I tested ldas_setup with ladas options. It needs one fix in setup_utils.py : add "from datetime import timedelta ". After the fix the experiments are set up correctly. |
Thanks, @saraqzhang, for taking look so quickly. @weiyuan-jiang, I added the import statement. |
…ile (setup_utils.py)
Initial check in. The class will be broken up into smaller steps.
This PR addresses issues #113 and #134.
Note: The ldas_setup changes impact #54 (irrigation), #131 (routing), and #132 (CatchCN51). Chances are that for each of these PRs, updating ldas_setup after the present PR has been merged will result in conflicts and require manual updates.