Skip to content

Conversation

@weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Apr 10, 2024

Add functionality to simulate landice tiles in GEOSldas.

See GEOS-ESM/GEOS_Util#137 for test results.

Dependencies:

Note: CI build tests of the present PR failed prior to the merging of GEOS-ESM/GEOSldas#705 because of the dependency on the changes in GEOS-ESM/GEOSldas#705

@weiyuan-jiang weiyuan-jiang added enhancement New feature or request 0-diff labels Apr 10, 2024
@gmao-rreichle
Copy link
Collaborator

@weiyuan-jiang: I just came across the following assumption in pre-processing: the *.til file must have all of the land tiles at the beginning. This has worked so far, but it is not a safe assumption (as noted in my comment from 2020). You are probably already aware of it in the context of the present PR, but I'm mentioning it here just in case.

! assume all land tiles are at the beginning

    ! assume all land tiles are at the beginning
          ! UNSAFE ASSUMPTION! - reichle, 2 Aug 2020
          
          if (typ/=MAPL_Land .and. typ/=MAPL_Land_ExcludeFromDomain) then   ! exit if not land
             
             if (logit) then
                write (logunit,*) 'WARNING: Encountered first non-land tile in *.til file.'
                write (logunit,*) '         Stop reading *.til file under the assumption that'
                write (logunit,*) '           land tiles are first in *.til file.'
                write (logunit,*) '         This is NOT a safe assumption beyond Icarus-NLv[x] tile spaces!!'
             end if
             
             exit ! assuming land comes first in the til file
             
          end if

@gmao-rreichle
Copy link
Collaborator

@weiyuan-jiang: I just came across the following assumption in pre-processing...

PS: The exact same code appears again a couple of hundred lines later:

! assume all land tiles are at the beginning

@lcandre2
Copy link
Contributor

1d outputs now work well for landice only experiments. Modifications to the default history file have been added.
Screenshot 2025-04-30 at 9 13 55 AM
Screenshot 2025-04-30 at 9 14 15 AM

@lcandre2
Copy link
Contributor

Screenshot 2025-04-30 at 9 40 52 AM Screenshot 2025-04-30 at 9 41 25 AM

weiyuan-jiang and others added 15 commits April 30, 2025 11:55
…rocess_ldas_routines.F90)

- changed rc variable name from TILE_FILE_TYPE to TILE_FILE_FORMAT
- removed obsolete NC4 option for TILE_FILE_FORMAT
- changed variable name N_catg to N_tiles_land_g inside subroutine LDAS_read_til_file()
- corrected & clarifed comments
- edited comments and error messages for clarity
- replaced "catchment" --> "tile" where appropriate for clarity
- replaced "catchment_def_file" and "cat_def_file" with "catch_def_file" for consistency
- renamed MAPL_ExcludeFromDomain to ExcludeFromDomain (it's not a MAPL constant)
- removed unnecessary "implicit none" statements
- white-space changes
- changed variable names for clarity:
  - N_catg         --> N_tiles_land_g
  - N_catr         --> N_tiles_land_r
  - N_catf, N_catd --> N_tiles_land_f
Copy link
Collaborator

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiyuan-jiang : I went through the "Files changed" and tried to clean up. I committed the changes separately for each file. The cumulative changes can be seen wit this link:
https://github.com/GEOS-ESM/GEOSldas_GridComp/compare/a2d55fc..e5fad70?w=1
(white-space changes hidden)
The bulk of the changes is in one file: preprocess_ldas_routines.F90, and these changes are the trickiest ones:
e5fad70
Please review when you get a chance.

@weiyuan-jiang
Copy link
Contributor Author

@lcandre2 Please note that my last commit changes the input of TILE_TYPES. Now it becomes numbers with blank space as separator.

@gmao-rreichle gmao-rreichle marked this pull request as ready for review May 19, 2025 13:52
@gmao-rreichle gmao-rreichle merged commit bfd97b3 into develop May 19, 2025
14 of 18 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/wjiang/add_landice branch May 19, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-diff enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants