-
Notifications
You must be signed in to change notification settings - Fork 0
add python scripts for computing stats of ObsFcstAna output (via intermediate monthly files) #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gmao-rreichle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmao-qliu, I added a few thoughts. Please take a look and let me know if you have any questions or concerns. Thanks!
GEOSldas_App/util/postproc/ObsFcstAna_stats/helper/smapeasev2.py
Outdated
Show resolved
Hide resolved
GEOSldas_App/util/postproc/ObsFcstAna_stats/helper/smapeasev2.py
Outdated
Show resolved
Hide resolved
GEOSldas_App/util/postproc/ObsFcstAna_stats/helper/compute_monthly_stats.py
Outdated
Show resolved
Hide resolved
GEOSldas_App/util/postproc/ObsFcstAna_stats/helper/read_GEOSldas.py
Outdated
Show resolved
Hide resolved
|
@gmao-qliu : I removed the binary files in the pycache/ directories from the repository. I don't think these should be under version control. |
|
Multi-experiments cross-masking is enabled now. @amfox37 @gmao-rreichle |
GEOSldas_App/util/postproc/ObsFcstAna_stats/helper/compute_monthly_stats.py
Outdated
Show resolved
Hide resolved
…SM/GEOSldas_GridComp into feature/qliu/add_postproc_scripts
|
I have gone ahead and added the capability to calculate monthly OmF mean etc statistics from the precomputed sums/sum of squares. I'm not entirely sure it belongs in the Main_example.py as I've inserted it, let's discuss. |
…oc_ObsFcstAna.py, user_config.py)
…sFcstAna.py, user_config.py)
…_ObsFcstAna_stats.py, Plot_stats_*.py)
gmao-rreichle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmao-qliu : I added a few more commits:
- Here's a link that shows the cumulative changes (white-space differences are hidden): https://github.com/GEOS-ESM/GEOSldas_GridComp/compare/f02efb4..fe2b15a?w=1
The most likely source of errors in my changes is in my addition of a check for obsparam across the exp_list: d1852a8
Please take a look and let me know if anything needs fixing. - What did we decide to do about the stats of the normalized O-F? If I recall correctly, as implemented the stats differ from what we did with the old Matlab scripts. Are we still thinking of trying to change this so it becomes identical to what we did in Matlab? If not, we need to add documentation in Plot_stats_maps.py.
I added some comments regarding the current approach. We can change the approach later if needed. |
…) (Get_ObsFcstAna_stats.py)
…stats_maps.py, Plot_stats_timeseries.py)
|
@gmao-qliu : I made a few more changes to clean up and clarify things. Here's a link to the cumulative differences of my commits of today: https://github.com/GEOS-ESM/GEOSldas_GridComp/compare/84c3b58..5d42392 This leaves the following comment as the only one that may still need resolution: #87 (comment) (re. the potentially excessive length of the names of the files that hold the monthly sums) |
@gmao-rreichle, Please review my latest commit to address this issue. |
This comment was marked as duplicate.
This comment was marked as duplicate.
@gmao-rreichle Looks and tests all good to me. |
Add python scripts for computing ObsFcstAna statistics.
Processing is broken down into three steps:
Steps 1) and 2) are generic for all ObsFcstAna output. Stats are computed in the tile space of the DA experiment and for all obs species (separately) in the associated obs_param file.
Step 3) depends on the assimilation experiment and use case scenario. E.g., SMAP L4_SM stats are defined in the EASEv2 M09 tile space but are usually aggregated across H/V-pol and AM/PM ops and visualized on the EASEv2 M36 grid.
The main script serves as a template to show how to use the pre-processed data to compute and plot the usual O-F and O-A statistical metrics.
The intermediate monthly stats nc4 files contain:
dimensions:
variables:
To facilitate the aggregation of the intermediate stats in Step 2), zeros are not replaced with NaNs in the "sum" variables even when the corresponding N_data value is zero.
Related issue: GEOS-ESM/GEOSldas#798 (closed)