Skip to content

Conversation

@amfox37
Copy link
Contributor

@amfox37 amfox37 commented May 19, 2025

Analysis of MODIS Aqua and Terra snow cover fraction (SCF) observations showed many "bad" (high) observations were passing existing QC using observation QC flags, even when using the most conservative settings.
Following existing templates for model-based QC we have added a subroutine to replace predicted asnow observations with a missing value when temperature of soil layer 1 exceeds a hardwired threshold.
After some sensitivity testing this threshold is currently set to 10 degrees C.

Successfully 0-diff tested by @gmao-rreichle after 59aa257
(For tests with aggressive builds, the "catparam" file comparison failed within roundoff for cdcr1.)

@amfox37 amfox37 added the enhancement New feature or request label May 19, 2025
…up of comments (clsm_ensupd_upd_routines.F90)
@gmao-rreichle
Copy link
Collaborator

Thanks, @amfox37, for putting this together. I just added a small change (59aa257) which I think is critical when running only SCF assimilation. Please double-check.
cc: @lcandre2

@amfox37
Copy link
Contributor Author

amfox37 commented May 21, 2025

Thanks, @amfox37, for putting this together. I just added a small change (59aa257) which I think is critical when running only SCF assimilation. Please double-check. cc: @lcandre2

Yes, I've double checked and this is now working when you only have SCF obs and with update_type 11. My bad for not checking this before - obviously I had multiple obs types in the obs_param namelist soget_tp_l was being called...

@gmao-rreichle gmao-rreichle marked this pull request as ready for review May 22, 2025 21:43
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner May 22, 2025 21:43
@gmao-rreichle gmao-rreichle merged commit c0ec27d into develop May 22, 2025
13 of 14 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/amfox/scf_model_based_qc branch May 22, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-diff enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants