-
Notifications
You must be signed in to change notification settings - Fork 0
Auto PR - develop β MAPL-v3 - minor edit insert adas_cyc input in JOB_SGMT #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: ldas_setup
β¦tup): - renamed new command line arguments - edited comments & help messages for clarity - cleaned up white space and indent
edit lines responding to comments
remove outdated sample files
Co-authored-by: Weiyuan Jiang <[email protected]>
β¦S setup (ldas_setup)
β¦ile (ldas_setup)
β¦as_setup): - cleaned up "ladas_cpl" variable names and processing - connected END_DATE to JOB_SGMT - for ladas_cpl>0 - for now, changed default n-tasks-per-node to 46 so it works with Cascade Lake - exclude unnecessary "required exe inputs" from sample file - simplified processing of model parameter defaults from GEOS_SurfaceGridComp.rc - edited comments - white space changes
β¦changes (ldas_setup)
- do not repeat identical lines when processing HISTORY file for coupled land-atm DAS - for length of ADAS analysis window, use variable name and units as in fvsetup - removed hardwired length of ADAS analysis window to determine END_DATE - for coupled land-atm DAS, ensure all command line args are supplied - renamed command line arg for LDAS nml input files
β¦ ADAS analyis window (ldas_setup)
- cleaned up logic of processing resource manager inputs - reverted to relative paths for rc files in ./etc - documentation of new functionality - updated language about compute nodes in sample batinp file (removed Skylake, added Milan) - fixed indentation
β¦lly resolved conflict in CHANGELOG.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Automatic PR:
developβrelease/MAPL-v3Description
π Modified files
.circleci/config.yml | 6 +-
.github/workflows/workflow.yml | 16 +-
CHANGELOG.md | 17 +-
GEOSldas_App/ldas_setup | 1054 +++++++++++--------
GEOSldas_App/lenkf_j_template.py | 10 +
.../LADAS/HISTORY.rc.atmens (gone) | 1083 --------------------
.../LADAS/HISTORY.rc.central (gone) | 98 --
.../LADAS/exeinp.txt.Hy4dEnVar.atmens (gone) | 48 -
.../LADAS/exeinp.txt.Hy4dEnVar.central (gone) | 50 -
9 files changed, 657 insertions(+), 1725 deletions(-)