Skip to content

Filter out data gridcomps#360

Merged
pchakraborty merged 2 commits intorelease/MAPL-v3from
feature/pchakrab/filter-out-data-gridcomps
Sep 22, 2025
Merged

Filter out data gridcomps#360
pchakraborty merged 2 commits intorelease/MAPL-v3from
feature/pchakrab/filter-out-data-gridcomps

Conversation

@pchakraborty
Copy link
Collaborator

@pchakraborty pchakraborty commented Sep 19, 2025

Several changes in GOCART2G

  • Use MAPL_GridCompGetChildName and call its run phase if it's not a data gridcomp
  • Use macros _SET/GET_NAMED_PRIVATE_STATE
  • Some more cleanup

@pchakraborty pchakraborty self-assigned this Sep 19, 2025
@pchakraborty pchakraborty added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Sep 19, 2025
@pchakraborty pchakraborty requested a review from a team as a code owner September 19, 2025 17:04
@pchakraborty pchakraborty added Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs MAPL3 labels Sep 19, 2025
@pchakraborty
Copy link
Collaborator Author

pchakraborty commented Sep 19, 2025

@tclune GOCART edits

@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, MAPL3

3 similar comments
@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, MAPL3

@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, MAPL3

@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, MAPL3

tclune
tclune reviewed Sep 19, 2025
View reviewed changes
@pchakraborty pchakraborty added the Skip Changelog Skip changelog enforcer label Sep 22, 2025
@github-actions
Copy link

github-actions bot commented Sep 22, 2025

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA, Skip Changelog, MAPL3

@pchakraborty pchakraborty removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Sep 22, 2025
@pchakraborty pchakraborty merged commit aacfcce into release/MAPL-v3 Sep 22, 2025
26 of 39 checks passed
@pchakraborty pchakraborty deleted the feature/pchakrab/filter-out-data-gridcomps branch September 22, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tclune tclune tclune left review comments

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees

@pchakraborty pchakraborty

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch. MAPL3 Skip Changelog Skip changelog enforcer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pchakraborty @mathomp4 @tclune