Feature/pcolarco/merge dev chemistry #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation of sulfate surface area and effective radius based on optical tables
…st settling call in Process Library accordingly
…e; add dedicated photolysis table entry in state; add hooks to use dedicated photolysis table and start to read legendre coefficients of P11
…ling' into feature/pcolarco/merge_chemistry Merging chemistry coupling and new photolysis calculator
pcolarco
added
the
0 diff
vbuchard
previously approved these changes
Dec 15, 2025
Collaborator
|
@mathomp4 It looks like the same test is failing as in the other PR. Can you please merge it. Thanks |
Member
This branch was out of date with develop. I've updated the branch. Once things build on circleci, I'll merge in. |
Member
Oh. Wait, the merge just brought in some changelog diffs: No need to wait. I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges two older branches (chem_coupling and photolysis_coupling) that extend capabilities if running with GMI chemistry.