Feature/pcolarco/fix su optics #367
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e made friendly to physics; commented that out
…Process Library and add some further clarifying comment in SU2G_GridCompMod
Co-authored-by: Matthew Thompson <[email protected]> Co-authored-by: acollow <[email protected]> Co-authored-by: Atanas Trayanov <[email protected]> Co-authored-by: William Putman <[email protected]>
hotfix/acollow/opticsfilepathtypo
- Fixed SettlingSolver to ensure no division by zero and mass conservation
add bottom layer settling to keep to current formulation
|
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bugfix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been updated already, but the optics need to be bumped to v1_6 for SU for compatibility with new settling codes. Already correct in "ops" but not in AMIPs.