Skip to content

Conversation

@pcolarco
Copy link
Contributor

This should have been updated already, but the optics need to be bumped to v1_6 for SU for compatibility with new settling codes. Already correct in "ops" but not in AMIPs.

@pcolarco pcolarco requested a review from a team as a code owner December 15, 2025 15:12
@pcolarco pcolarco added the bugfix This is a bug fix label Dec 15, 2025
@vbuchard vbuchard added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Non 0-diff The changes in this pull request are non-zero-diff labels Dec 15, 2025
@vbuchard
Copy link
Collaborator

@mathomp4 do you know why one Build GEOSgcm is failing? Thanks

@mathomp4
Copy link
Member

@mathomp4 do you know why one Build GEOSgcm is failing? Thanks

@vbuchard Huh. Nope. I think it was just some weird Github issue? I've re-submitted it, but, honestly, it passed on CircleCI, so it does build. I can merge in with powers if you don't want to wait.

@vbuchard
Copy link
Collaborator

@mathomp4 do you know why one Build GEOSgcm is failing? Thanks

@vbuchard Huh. Nope. I think it was just some weird Github issue? I've re-submitted it, but, honestly, it passed on CircleCI, so it does build. I can merge in with powers if you don't want to wait.

Yes, please if that still don't work. Thanks @mathomp4

@mathomp4 mathomp4 merged commit b4b154c into develop Dec 15, 2025
41 of 45 checks passed
@mathomp4 mathomp4 deleted the feature/pcolarco/fix_SU_optics branch December 15, 2025 17:42
@mathomp4
Copy link
Member

@mathomp4 do you know why one Build GEOSgcm is failing? Thanks

@vbuchard Huh. Nope. I think it was just some weird Github issue? I've re-submitted it, but, honestly, it passed on CircleCI, so it does build. I can merge in with powers if you don't want to wait.

Yes, please if that still don't work. Thanks @mathomp4

@vbuchard Merged. I prefer the CI in #363 anyway. I'll update that PR and test there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This is a bug fix Non 0-diff The changes in this pull request are non-zero-diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants