-
Notifications
You must be signed in to change notification settings - Fork 21
instance RC settings for v12 #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@acollow I don't think this was done quite right. If you are making a PR for v12, you should probably start with NOTE: I did try updating the base to |
|
Yes, you are correct that @sdrabenh's v12 is out of date. We discussed this at the GOCART and modeling meetings earlier in the week. The plan is to move forward with the initial release of v12 without the GOCART updates. In the meantime, @vbuchard will work on putting out two releases for GOCART 2.5.*. The code will be identical, and include all the necessary updates for v12 but the first release will have the settings for v11 and the second will have the settings for v12. Once all of this is completed, I will test GCM v12 with our GOCART release to determine if additional tuning is necessary, and then subsequently all of the GOCART changes will go into a GCM v12.1 release. |
Okay. So the thought is #370 goes in first? There's a release, and then #371? I was just surprised to see both going to v12. To that end, I'll apply the same CI updates I did to #370 to #371 then (as it seemed to have worked). |
…/updateinstancefiles
Yup, that's right! |
|
And I of course meant: I was just surprised to see both going to |
# Conflicts: # ESMF/GOCART2G_GridComp/SU2G_GridComp/AMIP.20C/SU2G_instance_SU.rc # ESMF/GOCART2G_GridComp/SU2G_GridComp/AMIP/SU2G_instance_SU.rc
|
@acollow I merge Also, SS did not have a pressure_lid change it seems. Should it be 0.01? |
All species should have a pressure_lid of 0.01 in v11. The actual values for pressure_lid may change again. Bill messaged saying he is testing 1 mb instead of 10 mb. Perhaps I am missing something but there should be additional lines modified for dust and sea salt that I am not seeing in the current version of files changed. |
|
I am closing this PR for the time being and will put in a new one as the pressure lids need to be updated again, and the sea salt and dust emissions factors were lost in the merge to the updated develop. |
Probably the safe thing to do! Wait for Bill to finalize and then update :) |
No description provided.