Skip to content

Conversation

@acollow
Copy link
Contributor

@acollow acollow commented Jan 8, 2026

No description provided.

@acollow acollow requested a review from vbuchard January 8, 2026 19:03
@acollow acollow requested a review from a team as a code owner January 8, 2026 19:03
@acollow acollow added the Non 0-diff The changes in this pull request are non-zero-diff label Jan 8, 2026
@mathomp4 mathomp4 changed the base branch from develop to feature/sdrabenh/gcm_v12 January 9, 2026 00:00
@mathomp4 mathomp4 requested review from a team as code owners January 9, 2026 00:00
@mathomp4 mathomp4 changed the base branch from feature/sdrabenh/gcm_v12 to develop January 9, 2026 00:00
@mathomp4
Copy link
Member

mathomp4 commented Jan 9, 2026

@acollow I don't think this was done quite right. If you are making a PR for v12, you should probably start with feature/sdrabenh/gcm_v12. That is where v12-specific development is happening.

NOTE: I did try updating the base to feature/sdrabenh/gcm_v12 but it went crazy. It looks like develop and feature/sdrabenh/gcm_v12 haven't been kept in sync. I made a draft PR here with a merge:

#372

@acollow
Copy link
Contributor Author

acollow commented Jan 9, 2026

Yes, you are correct that @sdrabenh's v12 is out of date. We discussed this at the GOCART and modeling meetings earlier in the week. The plan is to move forward with the initial release of v12 without the GOCART updates. In the meantime, @vbuchard will work on putting out two releases for GOCART 2.5.*. The code will be identical, and include all the necessary updates for v12 but the first release will have the settings for v11 and the second will have the settings for v12. Once all of this is completed, I will test GCM v12 with our GOCART release to determine if additional tuning is necessary, and then subsequently all of the GOCART changes will go into a GCM v12.1 release.

@mathomp4
Copy link
Member

mathomp4 commented Jan 9, 2026

Yes, you are correct that @sdrabenh's v12 is out of date. We discussed this at the GOCART and modeling meetings earlier in the week. The plan is to move forward with the initial release of v12 without the GOCART updates. In the meantime, @vbuchard will work on putting out two releases for GOCART 2.5.*. The code will be identical, and include all the necessary updates for v12 but the first release will have the settings for v11 and the second will have the settings for v12. Once all of this is completed, I will test GCM v12 with our GOCART release to determine if additional tuning is necessary, and then subsequently all of the GOCART changes will go into a GCM v12.1 release.

Okay. So the thought is #370 goes in first? There's a release, and then #371? I was just surprised to see both going to v12.

To that end, I'll apply the same CI updates I did to #370 to #371 then (as it seemed to have worked).

@acollow
Copy link
Contributor Author

acollow commented Jan 9, 2026

Yes, you are correct that @sdrabenh's v12 is out of date. We discussed this at the GOCART and modeling meetings earlier in the week. The plan is to move forward with the initial release of v12 without the GOCART updates. In the meantime, @vbuchard will work on putting out two releases for GOCART 2.5.*. The code will be identical, and include all the necessary updates for v12 but the first release will have the settings for v11 and the second will have the settings for v12. Once all of this is completed, I will test GCM v12 with our GOCART release to determine if additional tuning is necessary, and then subsequently all of the GOCART changes will go into a GCM v12.1 release.

Okay. So the thought is #370 goes in first? There's a release, and then #371? I was just surprised to see both going to v12.

To that end, I'll apply the same CI updates I did to #370 to #371 then (as it seemed to have worked).

Yup, that's right!

@mathomp4
Copy link
Member

mathomp4 commented Jan 9, 2026

And I of course meant:

I was just surprised to see both going to develop. Sigh. Brain not doing good today.

# Conflicts:
#	ESMF/GOCART2G_GridComp/SU2G_GridComp/AMIP.20C/SU2G_instance_SU.rc
#	ESMF/GOCART2G_GridComp/SU2G_GridComp/AMIP/SU2G_instance_SU.rc
@mathomp4
Copy link
Member

@acollow I merge develop into this and had to fix some conflicts. Can you make sure these are what v12 would want?

Also, SS did not have a pressure_lid change it seems. Should it be 0.01?

@acollow
Copy link
Contributor Author

acollow commented Jan 15, 2026

@acollow I merge develop into this and had to fix some conflicts. Can you make sure these are what v12 would want?

Also, SS did not have a pressure_lid change it seems. Should it be 0.01?

All species should have a pressure_lid of 0.01 in v11. The actual values for pressure_lid may change again. Bill messaged saying he is testing 1 mb instead of 10 mb. Perhaps I am missing something but there should be additional lines modified for dust and sea salt that I am not seeing in the current version of files changed.

@acollow
Copy link
Contributor Author

acollow commented Jan 15, 2026

I am closing this PR for the time being and will put in a new one as the pressure lids need to be updated again, and the sea salt and dust emissions factors were lost in the merge to the updated develop.

@acollow acollow closed this Jan 15, 2026
@mathomp4
Copy link
Member

I am closing this PR for the time being and will put in a new one as the pressure lids need to be updated again, and the sea salt and dust emissions factors were lost in the merge to the updated develop.

Probably the safe thing to do! Wait for Bill to finalize and then update :)

@acollow acollow deleted the feature/acollow/updateinstancefiles branch January 21, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Non 0-diff The changes in this pull request are non-zero-diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants