Skip to content

Use named alias id, instead of gridcomp+short names to set and retrieve restart mode of an import item#4031

Merged
pchakraborty merged 14 commits intorelease/MAPL-v3from
feature/pchakrab/use-named-alias-id
Sep 24, 2025
Merged

Use named alias id, instead of gridcomp+short names to set and retrieve restart mode of an import item#4031
pchakraborty merged 14 commits intorelease/MAPL-v3from
feature/pchakrab/use-named-alias-id

Conversation

@pchakraborty
Copy link
Contributor

@pchakraborty pchakraborty commented Sep 4, 2025

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Use named alias id of a field, instead of gridcomp+short names to set and retrieve restart mode from the internal section of its info object. This is used to check which import item has its restart mode set to MAPL_RESTART_SKIP

NOTE - Build is going to fail till the CI Baselibs have been updated to include the version of ESMF that implements NamedAlias identifier

Related Issue

Fixed #4001

@pchakraborty pchakraborty self-assigned this Sep 4, 2025
@pchakraborty pchakraborty added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs 🛠️ Refactor This is code refactoring 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Sep 4, 2025
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This information belongs in the "internal" section of the info object. "private" is for user gridcomp-specific things.

1. Switched from an enum to respresent restart modes, to a derived type (fixes #4001)
2. Added FieldInfo::field_info_g/set_internal_restart_mode (interface FieldInfoG/SetInternal) to retrieve and set the internal info
@pchakraborty pchakraborty force-pushed the feature/pchakrab/use-named-alias-id branch from 012462f to 9ceb120 Compare September 5, 2025 12:27
@pchakraborty
Copy link
Contributor Author

This information belongs in the "internal" section of the info object. "private" is for user gridcomp-specific things.

@tclune Added the info to the internal section of the info object.

@pchakraborty pchakraborty changed the title Use named alias id, instead of gridcomp+short names to set and retrieve private state of a field Use named alias id, instead of gridcomp+short names to set and retrieve restart mode of an import item Sep 5, 2025
tclune
tclune previously approved these changes Sep 5, 2025
@pchakraborty pchakraborty marked this pull request as ready for review September 23, 2025 17:56
@pchakraborty pchakraborty requested a review from a team as a code owner September 23, 2025 17:56
@pchakraborty pchakraborty added 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs and removed 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs labels Sep 23, 2025
@pchakraborty pchakraborty removed the 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Sep 23, 2025
@pchakraborty pchakraborty merged commit da4f012 into release/MAPL-v3 Sep 24, 2025
33 of 34 checks passed
@pchakraborty pchakraborty deleted the feature/pchakrab/use-named-alias-id branch September 24, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants