Make ExtensionTransform ESMF_Field names public character parameters#4079
Merged
darianboggs merged 6 commits intorelease/MAPL-v3from Sep 23, 2025
Merged
Conversation
tclune
reviewed
Sep 19, 2025
tclune
requested changes
Sep 19, 2025
Collaborator
tclune
left a comment
There was a problem hiding this comment.
I think the name parameters should just be in the base class.
Is there any reason to have them vary for subclasses?
tclune
reviewed
Sep 22, 2025
tclune
requested changes
Sep 22, 2025
Collaborator
tclune
left a comment
There was a problem hiding this comment.
I made a suggestion - should just be a simple global replace if you agree.
tclune
previously approved these changes
Sep 22, 2025
Contributor
Author
|
Numerous tests failed. The problem was that the field names were changed from |
tclune
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
The names of the
ESMF_Fieldobjects in theESMF_Stateobjects in subclasses ofExtensionTransformwere previously private. This made it difficult to test the subclasses. This PR adds publiccharacterparameters for the names.