Skip to content

Make ExtensionTransform ESMF_Field names public character parameters#4079

Merged
darianboggs merged 6 commits intorelease/MAPL-v3from
feature/wdboggs/makeTranformFieldNamesParameters
Sep 23, 2025
Merged

Make ExtensionTransform ESMF_Field names public character parameters#4079
darianboggs merged 6 commits intorelease/MAPL-v3from
feature/wdboggs/makeTranformFieldNamesParameters

Conversation

@darianboggs
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

The names of the ESMF_Field objects in the ESMF_State objects in subclasses of ExtensionTransform were previously private. This made it difficult to test the subclasses. This PR adds public character parameters for the names.

@darianboggs darianboggs self-assigned this Sep 19, 2025
@darianboggs darianboggs requested a review from a team as a code owner September 19, 2025 14:47
@darianboggs darianboggs added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels Sep 19, 2025
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name parameters should just be in the base class.

Is there any reason to have them vary for subclasses?

@darianboggs darianboggs requested a review from tclune September 19, 2025 15:36
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a suggestion - should just be a simple global replace if you agree.

tclune
tclune previously approved these changes Sep 22, 2025
@darianboggs
Copy link
Contributor Author

Numerous tests failed. The problem was that the field names were changed from import[1] and export[1] to coupler_import and coupler_export, respectively. I kept the parameter names, but I changed the parameter values back to import[1] and export[1]. The tests pass. Since having public parameters for testing was the goal of this PR, I pushed the changes up, and it's ready for final approval. A future PR can implement the new parameter values, if it is necessary.

@darianboggs darianboggs requested a review from tclune September 23, 2025 02:28
@darianboggs darianboggs merged commit 8400ba8 into release/MAPL-v3 Sep 23, 2025
29 checks passed
@darianboggs darianboggs deleted the feature/wdboggs/makeTranformFieldNamesParameters branch September 23, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants