Conversation
tclune
reviewed
Sep 22, 2025
tclune
reviewed
Sep 22, 2025
tclune
reviewed
Sep 22, 2025
tclune
reviewed
Sep 22, 2025
tclune
previously approved these changes
Sep 22, 2025
tclune
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4059
This allows extdata to set a flag that the regridding can queue off of to decide whether the bracket needs regridding.
As usual confirmed it work via prints but couldn't think of a good test.
I didn't know how far to take this. I added a new FieldBundle method to detect if the attribute is present, but only for the new one, I didn't do it for every option for fieldGet/Set
Also this is only for fieldBundles so no way if you are just regridding a field you could do something similar.
This was really the minimum needed...
Thought I would put it out here before going more crazy
Types of change(s)
Checklist
make tests)Description
Related Issue