Skip to content

Fixes #4059#4083

Merged
bena-nasa merged 11 commits intorelease/MAPL-v3from
feature/bmauer/fixes-#4059
Sep 23, 2025
Merged

Fixes #4059#4083
bena-nasa merged 11 commits intorelease/MAPL-v3from
feature/bmauer/fixes-#4059

Conversation

@bena-nasa
Copy link
Collaborator

Fixes #4059

This allows extdata to set a flag that the regridding can queue off of to decide whether the bracket needs regridding.
As usual confirmed it work via prints but couldn't think of a good test.

I didn't know how far to take this. I added a new FieldBundle method to detect if the attribute is present, but only for the new one, I didn't do it for every option for fieldGet/Set

Also this is only for fieldBundles so no way if you are just regridding a field you could do something similar.

This was really the minimum needed...
Thought I would put it out here before going more crazy

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@bena-nasa bena-nasa requested a review from a team as a code owner September 22, 2025 18:30
@bena-nasa bena-nasa added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Sep 22, 2025
@bena-nasa bena-nasa requested a review from tclune September 22, 2025 18:30
tclune
tclune previously approved these changes Sep 22, 2025
@bena-nasa bena-nasa merged commit f052127 into release/MAPL-v3 Sep 23, 2025
27 of 29 checks passed
@bena-nasa bena-nasa deleted the feature/bmauer/fixes-#4059 branch September 23, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants