Fixes #3961 statistics gridcomp #4285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New change results in most unused fields being GRIDSET rather than EMPTY. It is possible that this is not strictly necessary, but seems harmless.
- Functions that return allocatable objects must ensure that it is always allocated - even when errors occur. - Improved error message for rank > 4.
These mostly are due to the fact that unused exports now generally have field status of GRIDSET where before they were EMPTY. This is probably fixable if it is important, but a shallow copy of an ESMF geom seems minor.
Lots of small changes to ensure compatibility with retrieval to/from state item aspects.
(Functionality is elsewhere now.)
Necessary due to use of VerticalGridManager now.
Might be the fix for #3343. Empirically seems true.
Was reluctant to delete hard won understanding of useful debugging info.
Useful bit for debugging. Also should migrate to pflogger.
We need the spec to be properly updated from the payload before analyzing for extensions. This line could possibly move elsewhere though.
Still lots of code that should now be deletable. Next pass.
- updated payload at appropriate point - new diagnostic procedure (print_spec) - pass through treatment of deferred aspects (must be in info now)
Some refactoring should reduce redundancy.
- need to use POINTER in some contexts - more care with detecting mirror case
- Basic use case now functions correctly. - Reordered tests to isolate the ones that sometimes trigger NAG "MAPL_Verify()" bug. (Hopefully now resolved.)
All aspects need superior testing now.
Works differently now with info and grid manager.
New FieldSet and FieldBundleSet replace that functionality. (Separate PR will delete the legacy layer.)
- eleminated some print statements - needs more tests
Necessary for use with VerticalGridManager.
tclune
added
0 Diff
atrayano
reviewed
Jan 5, 2026
atrayano
previously approved these changes
Jan 5, 2026
Library name error was missed due to case-insensive file system in development environment.
- Not crucial, but found a few irregularities while investigating a different issue.
Retrieving params in FieldSetGet was causing cyclic dependencies. So now we put the burden on the client code to translate to/from an info object.
Surprisingly only showed up with gfortran + release.
atrayano
previously approved these changes
Jan 8, 2026
tclune
commented
Jan 8, 2026
tclune
commented
Jan 8, 2026
atrayano
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
Long time coming.
Related Issue