Skip to content

Added utilities directory with array and regex utilities #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pchakraborty merged 5 commits into from
Jan 7, 2026
Merged

Added utilities directory with array and regex utilities #4298

pchakraborty merged 5 commits into from
Jan 7, 2026

Conversation

@pchakraborty
Copy link
Contributor

@pchakraborty pchakraborty commented Jan 6, 2026

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

  • Added utilities/arrays with routines to compute global MaxMin and AreaMean
  • Added tests for array utilities
  • Copied over regex utilities from base to utilities/regex

Related Issue

@pchakraborty pchakraborty requested a review from a team as a code owner January 6, 2026 14:10
@pchakraborty pchakraborty self-assigned this Jan 6, 2026
@pchakraborty pchakraborty added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Jan 6, 2026
darianboggs
darianboggs reviewed Jan 6, 2026
View reviewed changes
darianboggs
darianboggs reviewed Jan 6, 2026
View reviewed changes
darianboggs
darianboggs reviewed Jan 6, 2026
View reviewed changes
@tclune
Copy link
Collaborator

tclune commented Jan 6, 2026

Lets not belabor this. Lots of cleanup remains ...

darianboggs
darianboggs previously requested changes Jan 6, 2026
View reviewed changes
@tclune tclune self-requested a review January 6, 2026 18:06
tclune
tclune previously approved these changes Jan 6, 2026
View reviewed changes
@pchakraborty pchakraborty requested a review from tclune January 6, 2026 18:46
@pchakraborty pchakraborty dismissed darianboggs’s stale review January 6, 2026 19:07

I’ll talk to Bill and create issues for separate PRs as needed

@pchakraborty pchakraborty merged commit b63e778 into release/MAPL-v3 Jan 7, 2026
33 checks passed
@pchakraborty pchakraborty deleted the feature/pchakrab/utilities-maxmin-areamean branch January 7, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darianboggs darianboggs darianboggs left review comments

@tclune tclune tclune approved these changes

Assignees

@pchakraborty pchakraborty

Labels

0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pchakraborty @tclune @darianboggs