conversion of units location #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biljanaorescanin
added
the
0 diff
Author
|
I've run few resolutions, once all finish I will update main path in bcs_shared. |
Member
|
@biljanaorescanin Any other updates to this or shall I merge and tag? |
Author
|
Merge and tag! |
mathomp4
approved these changes
Aug 29, 2025
Member
|
@biljanaorescanin Tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For intermediate step and final output file (gwd_internal_rst) I am changing location where we convert units from variance to standard deviation.
I also fixed some units metadata inconstancies from legacy code and added more metadata info to sister PR for same files:
GEOS-ESM/GEOSgcm_GridComp#1054
@mathomp4 this should go on top of tag 2.0.1
(I am not sure I did it right, difference is right just one file, cube_to_target.F90. )