fix(confirm-dialog): add prop for accept label #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes the confirm dialog component to support customizable accept button labels instead of hardcoding "Quit" for all dialogs. This addresses issue #140 where the delete integration confirmation dialog incorrectly showed "Quit" instead of "Delete".
Changes:
- Added
acceptLabelas a required prop toConfirmWrappercomponent - Updated all 7 usages of
ConfirmWrapperacross the codebase with appropriate labels ("Quit", "Delete", or "Reset") - Fixed inconsistent import name from
DialogWrappertoConfirmWrapperin TimeTrailRaceModeView
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/prime/ConfirmWrapper.vue | Added acceptLabel prop and removed hardcoded "Quit" label |
| src/views/Modes/TimeTrailRaceModeView.vue | Added acceptLabel="Quit" and fixed import name from DialogWrapper to ConfirmWrapper |
| src/views/Modes/CenturionModeView.vue | Added acceptLabel="Quit" for centurion quit confirmation |
| src/components/timed-events/TimedEventDeleteButton.vue | Added acceptLabel="Delete" for timed event deletion |
| src/components/poster/StaticPosterButtonDelete.vue | Added acceptLabel="Delete" for poster deletion |
| src/components/modes/time-trail-race/TimeTrailRaceStepper.vue | Added acceptLabel="Reset" for trail race reset |
| src/components/integrations/IntegrationDeleteButton.vue | Added acceptLabel="Delete" for integration deletion (fixes issue #140) |
| src/components/audio/SpotifyUserDeleteButton.vue | Added acceptLabel="Delete" for Spotify user deletion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SuperVK
approved these changes
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add prop for the confirm dialog box to define the accept label, since it was used across the project with different meanings, all using the label 'Quit'
Related issues/external references
#140
Types of changes