Skip to content

Introduce time limit for mailman sync locking mechanism to avoid permanent failures#514

Merged
rinkp merged 2 commits intoGEWIS:mainfrom
rinkp:fix/list-sync-semaphore-timer
Feb 15, 2026
Merged

Introduce time limit for mailman sync locking mechanism to avoid permanent failures#514
rinkp merged 2 commits intoGEWIS:mainfrom
rinkp:fix/list-sync-semaphore-timer

Conversation

@rinkp
Copy link
Copy Markdown
Member

@rinkp rinkp commented Dec 7, 2025

Description

Introduces a 23-hour time limit on mailman sync locks. If the mailman sync is running for >23 hours without refreshing its lock, it is presumed to have failed.

To properly implement this, optimistic locking of configuration items is introduced.

Related issues/external references

Fixes GH-513.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (no changes to code)
  • Other (please specify)

Noteworthy

  • Requires database migration

@rinkp rinkp force-pushed the fix/list-sync-semaphore-timer branch 14 times, most recently from efe809c to 883ce77 Compare February 1, 2026 19:15
@rinkp rinkp force-pushed the fix/list-sync-semaphore-timer branch 7 times, most recently from 79df36f to 50ce18c Compare February 11, 2026 21:22
@rinkp
Copy link
Copy Markdown
Member Author

rinkp commented Feb 11, 2026

Removed any commits that do not belong on this branch; needs GH-516 to be able to run docker containers on this branch

@rinkp rinkp marked this pull request as ready for review February 11, 2026 21:23
tomudding
tomudding previously approved these changes Feb 15, 2026
This commit introduces a 23-hour time limit on mailman sync locks. If the mailman sync is running for >23 hours without refreshing its lock, it is presumed to have failed.
@rinkp rinkp force-pushed the fix/list-sync-semaphore-timer branch from cc0aa22 to 7bada6f Compare February 15, 2026 19:43
@rinkp rinkp enabled auto-merge February 15, 2026 19:45
@rinkp rinkp requested a review from tomudding February 15, 2026 19:45
@rinkp rinkp merged commit 3558594 into GEWIS:main Feb 15, 2026
5 checks passed
@rinkp rinkp deleted the fix/list-sync-semaphore-timer branch February 15, 2026 19:47
github-actions bot added a commit that referenced this pull request Feb 15, 2026
Rink: Merge pull request #514 from rinkp/fix/list-sync-semaphore-timer

Introduce time limit for mailman sync locking mechanism to avoid permanent failures

Co-authored-by: rinkp <rinkp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent database faults may cause permanent lock of mailman sync

2 participants