This repository was archived by the owner on Feb 5, 2026. It is now read-only.
Conversation
5ecd6e7 to
4d29a62
Compare
4d29a62 to
fc02094
Compare
fc02094 to
519f5b1
Compare
Make sure have latest version of libcoveweb2. Old ref to this was not locked - new ref will be locked. libcoverdls is not actually published as pypi package so use git link instead. Don't use editable link, as that can't be found in Docker containers Lock to latest commit. python-magic was missing from requirements.in Changes in Requirements.txt may be due to previous commits not building lock files properly. eg flattentool 0.23.0 does need shapely and geojson so they should have been in before. https://github.com/OpenDataServices/flatten-tool/blob/v0.23.0/setup.py#L42 Had to upgrade pip-tools as old version would not work
519f5b1 to
7a3b714
Compare
jarofgreen
approved these changes
May 1, 2025
Collaborator
jarofgreen
left a comment
There was a problem hiding this comment.
I'm approving to indicate I approve Ed's 2 commits, someone else should check my commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Point libcoveweb2 dependencies to version 0.4.0, and update workflows (actions and Python version).
Resolves: #31