Skip to content

Use upsert strategy #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arnaud-morvan merged 1 commit into from
Jan 5, 2026
Merged

Use upsert strategy #990

arnaud-morvan merged 1 commit into from
Jan 5, 2026

Conversation

@arnaud-morvan
Copy link
Contributor

@arnaud-morvan arnaud-morvan commented Dec 19, 2025

  • Add field admindiv.gaul
  • Do not use TRUNCATE CASCADE
  • Use UPSERT strategy for admindivs
  • Maintain contacts and recommandations relations using GAUL
  • Add class docstring

@arnaud-morvan
Copy link
Contributor Author

arnaud-morvan commented Dec 19, 2025

@ronitjadhav
I handled all relations properly. Don't hesitate to contact me by chat if something is not clear or if it desserve some comments, explanations.

@arnaud-morvan
Use upsert strategy
2b96e9b 
- Add field admindiv.gaul
- Do not use TRUNCATE CASCADE
- Use UPSERT strategy for admindivs
- Maintain contacts and recommandations relations using GAUL
- Add class docstring
@arnaud-morvan arnaud-morvan force-pushed the import-geopackage-upsert branch from ffa73b4 to 2b96e9b Compare December 19, 2025 20:51
@ronitjadhav
Copy link
Collaborator

ronitjadhav commented Dec 22, 2025

@arnaud-morvan
Got it, so we keep the admin div links (no truncation), swap codes via GAUL, and rely on the upsert to add/update rows as needed.

@arnaud-morvan arnaud-morvan merged commit 5b08086 into import-geopackage Jan 5, 2026
1 check passed
@arnaud-morvan arnaud-morvan deleted the import-geopackage-upsert branch January 5, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronitjadhav ronitjadhav ronitjadhav approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arnaud-morvan @ronitjadhav