Skip to content

Fix: prevent measures from defaulting to Auto format #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
galkatz7 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: prevent measures from defaulting to Auto format #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 30 additions & 30 deletions GINQO_MasterItemManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,36 +477,36 @@ function ($, qlik, mainModalWindow, helpModalWindow, dimModalWindow, dimModalCon
const formatType = getValueByKey(cells, "%MI%MeasureFormatType", "qText");

// Check if number format properties are provided
if (formatType.length > 0) {
const formatFmt = getValueByKey(cells, "%MI%MeasureFormatFmt", "qText");
const formatDec = getValueByKey(cells, "%MI%MeasureFormatDec", "qText");
const formatThou = getValueByKey(cells, "%MI%MeasureFormatThou", "qText");

var formatNDec;
if (formatType == 'U') {
formatNDec = 10;
} else {
formatNDec = 2;
}
const formatUseThou = 0; // always 0, parseInt(getValueByKey(cells, "%MI%MeasureFormatUseThou", "qText"));

const numberFormat = {
qnDec: formatNDec,
qUseThou: formatUseThou,
qFmt: formatFmt,
qDec: formatDec,
qType: formatType,
qThou: formatThou
}
// Assign the number format to the measure properties
properties.qMeasure.qNumFormat = numberFormat;
} else {
// If the number format is not provided, use existing values
properties.qMeasure.qNumFormat = existingNumber;
}
if (formatType && formatType.length > 0) {
const formatFmt = getValueByKey(cells, "%MI%MeasureFormatFmt", "qText");
const formatDec = getValueByKey(cells, "%MI%MeasureFormatDec", "qText");
const formatThou = getValueByKey(cells, "%MI%MeasureFormatThou", "qText");

// Logic: 'U' (Unknown) gets 10 decimals, others (Fixed, Money, etc.) get 2
let formatNDec = (formatType === 'U') ? 10 : 2;

properties.qMeasure.qNumFormat = {
qType: formatType,
qnDec: formatNDec,
qUseThou: 0,
qFmt: formatFmt || '',
qDec: formatDec || '',
qThou: formatThou || ''
};

// FIX: Explicitly disable Auto Format so Qlik uses the object above
properties.qMeasure.qIsAutoFormat = false;

} else {
// If Excel cell is blank, keep the existing Master Item format
if (existingNumber && Object.keys(existingNumber).length > 0) {
properties.qMeasure.qNumFormat = existingNumber;
properties.qMeasure.qIsAutoFormat = false;
} else {
// Fallback to Auto only if no format exists at all
properties.qMeasure.qIsAutoFormat = true;
}
}

// Determine the action (create or update) and perform the appropriate action
if (actionType === 'UPDATE') {
Expand Down