-
Notifications
You must be signed in to change notification settings - Fork 449
feat: enable ors surface ev #2110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This requires a version of graphhopper that contains the surface type enum as encoded value.
Encoded values need to be defined in GH codebase in order to be able to use them in custom profiles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables the OrsSurface encoded value for custom profiles by implementing the necessary parser infrastructure and updating the GraphHopper version. The change allows routing profiles to utilize surface type information (e.g., asphalt, gravel, dirt) in custom routing models.
- Upgrades GraphHopper version from v4.9.8 to v4.9.9
- Implements OrsSurfaceParser to handle surface tag parsing from OSM data
- Updates tag parser factory to register the new surface parser
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
pom.xml | Updates GraphHopper version to v4.9.9 |
OrsSurfaceParser.java | Implements new parser for surface encoded values with comprehensive surface type mapping |
OrsTagParserFactory.java | Registers OrsSurfaceParser in the tag parser factory |
OrsEncodedValueFactory.java | Refactors if-else to switch statement for better maintainability |
ORSGraphHopperConfig.java | Updates surface encoded value reference from Surface to OrsSurface |
ResultTest.java | Updates test to use correct encoded value name |
CHANGELOG.md | Documents the new feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for enabling the first ORS-specific encoded value! 🚀
|
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Related to #2107 .
Information about the changes