-
Notifications
You must be signed in to change notification settings - Fork 458
fix: add testcontainers annotations to status/ResultTest
#2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Address feedback on Feature Store implementation
Add testcontainers annotations to status/ResultTest
Nov 14, 2025
aoles
approved these changes
Nov 14, 2025
Member
aoles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤖
Co-authored-by: aoles <[email protected]>
9d25bf5 to
6612632
Compare
status/ResultTest
aoles
added a commit
that referenced
this pull request
Nov 18, 2025
Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: aoles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
status/ResultTestextendsAbstractContainerBaseTestwhich uses testcontainers for PostgreSQL setup, but was missing the required JUnit 5 testcontainers annotations.Changes:
@ExtendWith(TestcontainersExtension.class)to properly initialize testcontainers lifecycle@Testcontainers(disabledWithoutDocker = true)to skip tests when Docker is unavailableThis aligns with the pattern already used in
dynamicrouting/ResultTest.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.