-
Notifications
You must be signed in to change notification settings - Fork 464
feat: add Basque translation (#2206) #2207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add basque language support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds Basque (Euskara) language translation support to OpenRouteService by introducing a new locale resource file and registering the language codes in the API enums.
Key changes:
- New Basque translation file (ors_eu-ES.resources) with navigation instructions and directions
- Registration of EU and EU_ES language codes in the APIEnums.Languages enum
- Documentation of changes in CHANGELOG.md
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| ors-engine/src/main/resources/resources/locales/ors_eu-ES.resources | New Basque translation file containing navigation instructions, directions, and maneuvers |
| ors-api/src/main/java/org/heigit/ors/api/APIEnums.java | Adds EU and EU_ES language enum values to support Basque language in the API |
| CHANGELOG.md | Documents the addition of Basque translation file and language enum updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ors-engine/src/main/resources/resources/locales/ors_eu-ES.resources
Outdated
Show resolved
Hide resolved
ors-engine/src/main/resources/resources/locales/ors_eu-ES.resources
Outdated
Show resolved
Hide resolved
ors-engine/src/main/resources/resources/locales/ors_eu-ES.resources
Outdated
Show resolved
Hide resolved
ors-engine/src/main/resources/resources/locales/ors_eu-ES.resources
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…urces Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…urces Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aoles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution! ❤️
The translation looks really awesome! 🤩 There is only one minor issue with the CHANGELOG file, see my comment below. Do you think you could still address it?
Looking forward to hearing from you.
Cheers,
Andrzej
| - documentation on the fields of JSON and GeoJSON responses of the directions endpoint ([#2084](https://github.com/GIScience/openrouteservice/issue/2084)) | ||
| - docs: comment on API key usage ([#2179](https://github.com/GIScience/openrouteservice/pull/2179)) | ||
| - type-specific filtering for mapping point features to graph edges ([#2156](https://github.com/GIScience/openrouteservice/pull/2156)) | ||
| - documentation on the matching endpoint ([#2156](https://github.com/GIScience/openrouteservice/pull/2156)) | ||
| - PostgreSQL-backed feature store with scheduled synchronization for dynamic routing data updates ([#2156](https://github.com/GIScience/openrouteservice/pull/2156)) | ||
| - Enhance the docker image and docker build workflow for Kubernetes readiness with minimal image support ([#2183](https://github.com/GIScience/openrouteservice/pull/2183)) | ||
| - "What you get" section to the JAR setup documentation and API reference to the docker setup documentation ([#2203](https://github.com/GIScience/openrouteservice/pull/2203)) | ||
|
|
||
| ### Changed | ||
| - add Basque language support to APIEnums ([#2206](https://github.com/GIScience/openrouteservice/issue/2206)) | ||
| - enhanced status endpoint to expose dynamic data statistics and feature store metrics ([#2156](https://github.com/GIScience/openrouteservice/pull/2156)) | ||
| - when running in `preparation_mode`, pack the graph for upload ([#2185](https://github.com/GIScience/openrouteservice/pull/2185)) | ||
| - replace `HeavyVehicleAttributesGraphStorage` with corresponding encoded values ([#2146](https://github.com/GIScience/openrouteservice/pull/2146)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update to the CHANGELOG should contain only a single entry corresponding to this PR.



Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes #2206 .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)