Skip to content

feat: make highway:corridor foot-routable#2252

Open
koebi wants to merge 1 commit intomainfrom
feat/highway-corridor
Open

feat: make highway:corridor foot-routable#2252
koebi wants to merge 1 commit intomainfrom
feat/highway-corridor

Conversation

@koebi
Copy link
Copy Markdown
Collaborator

@koebi koebi commented Mar 28, 2026

Pull Request Checklist

  • 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes # .

Information about the changes

  • Key functionality added:
  • Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

Newer presets for mapping editors tend to start including more and more
corridors.
We should at least allow foot routing on them.
@koebi koebi force-pushed the feat/highway-corridor branch from 4a35184 to c433714 Compare March 28, 2026 13:11
@koebi koebi changed the title Feat/highway corridor feat: make highway:corridor foot-routable Mar 28, 2026
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@aoles aoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! ❤️

It would be helpful to know some context behind this PR. If possible, please consider adding one or two motivating sentences to the description.

On a technical note, please have a look at the comment below. It would also be great if you could add a line to the CHANGELOG under “Added”. Cheers! 🙏

"residential",
"service"
"service",
"corridor"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation appears to differ from that of the other values. Please consider standardizing the formatting to match the rest of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants